Skip to content

python3.pkgs.liquidctl: add build dependencies#248780

Merged
natsukium merged 1 commit intoNixOS:masterfrom
tjni:liquidctl
Aug 13, 2023
Merged

python3.pkgs.liquidctl: add build dependencies#248780
natsukium merged 1 commit intoNixOS:masterfrom
tjni:liquidctl

Conversation

@tjni
Copy link
Copy Markdown
Contributor

@tjni tjni commented Aug 12, 2023

Description of changes

Add missing build dependencies that will start to break the build once we can move to using build to build Python packages.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 12, 2023
@ofborg ofborg bot requested review from arcz and evils August 12, 2023 21:16
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Aug 12, 2023
@natsukium
Copy link
Copy Markdown
Member

@ofborg build python310Packages.liquidctl

@natsukium
Copy link
Copy Markdown
Member

Result of nixpkgs-review pr 248780 run on x86_64-linux 1

3 packages failed to build:
  • python311Packages.liquidctl
  • python311Packages.liquidctl.dist
  • python311Packages.liquidctl.man
5 packages built:
  • gkraken
  • gnomeExtensions.freon
  • liquidctl (python310Packages.liquidctl)
  • liquidctl.dist (python310Packages.liquidctl.dist)
  • liquidctl.man (python310Packages.liquidctl.man)

Copy link
Copy Markdown
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python311Packages.liquidctl is fixed in the next release, 1.13.0.

@natsukium natsukium merged commit af9458d into NixOS:master Aug 13, 2023
@tjni tjni deleted the liquidctl branch August 13, 2023 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants