python3.pkgs.pyqt-builder: 1.14.1 -> 1.15.2#248760
Merged
wegank merged 1 commit intoNixOS:stagingfrom Aug 13, 2023
tjni:pyqt-builder
Merged
python3.pkgs.pyqt-builder: 1.14.1 -> 1.15.2#248760wegank merged 1 commit intoNixOS:stagingfrom tjni:pyqt-builder
wegank merged 1 commit intoNixOS:stagingfrom
tjni:pyqt-builder
Conversation
Co-authored-by: rewine <lhongxu@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
https://www.riverbankcomputing.com/news/PyQt-builder_1.15.0_Released
https://www.riverbankcomputing.com/news/PyQt-builder_1.15.1_Released
https://www.riverbankcomputing.com/news/PyQt-builder_1.15.2_Released
This supersedes #237362. @wineee I hope it's all right, I had to make some additional changes to support some work I'm doing, and I added you as a co-author.
The motivation is that pyqt6 declares a build-time dependency on pyqt-builder >= 1.15.1, and soon we will have stronger build dependency validation. Updating this means we won't need to (temporarily) patch the constraint in pyqt6.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)