python3.pkgs.zigpy: add build dependencies and fix constraints#248757
Merged
tjni merged 1 commit intoNixOS:masterfrom Aug 17, 2023
tjni:zigpy
Merged
python3.pkgs.zigpy: add build dependencies and fix constraints#248757tjni merged 1 commit intoNixOS:masterfrom tjni:zigpy
tjni merged 1 commit intoNixOS:masterfrom
tjni:zigpy
Conversation
Contributor
Author
|
@ofborg build python3.pkgs.zigpy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Reason for these changes is that we will soon switch to building Python projects using
build, which comes with stricter build dependency validation.I decided to patch out setuptools-git-versioning, because the recommended way to override the version from upstream at the moment is to add a version file and update the project's pyproject.toml to point to it. This is not something that I want to explicitly request from zigpy owner, and it's fewer changes to apply the necessary patches to inject the version directly.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)