Skip to content

python3.pkgs.zigpy: add build dependencies and fix constraints#248757

Merged
tjni merged 1 commit intoNixOS:masterfrom
tjni:zigpy
Aug 17, 2023
Merged

python3.pkgs.zigpy: add build dependencies and fix constraints#248757
tjni merged 1 commit intoNixOS:masterfrom
tjni:zigpy

Conversation

@tjni
Copy link
Copy Markdown
Contributor

@tjni tjni commented Aug 12, 2023

Description of changes

Reason for these changes is that we will soon switch to building Python projects using build, which comes with stricter build dependency validation.

I decided to patch out setuptools-git-versioning, because the recommended way to override the version from upstream at the moment is to add a version file and update the project's pyproject.toml to point to it. This is not something that I want to explicitly request from zigpy owner, and it's fewer changes to apply the necessary patches to inject the version directly.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 12, 2023
@ofborg ofborg bot requested a review from mvnetbiz August 12, 2023 19:12
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Aug 12, 2023
@tjni
Copy link
Copy Markdown
Contributor Author

tjni commented Aug 17, 2023

@ofborg build python3.pkgs.zigpy

@tjni tjni merged commit 0a9ed08 into NixOS:master Aug 17, 2023
@tjni tjni deleted the zigpy branch August 17, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant