Skip to content

python310Packages.mdformat-beautysh: add missing input#248677

Merged
fabaff merged 2 commits intoNixOS:masterfrom
fabaff:master
Aug 23, 2023
Merged

python310Packages.mdformat-beautysh: add missing input#248677
fabaff merged 2 commits intoNixOS:masterfrom
fabaff:master

Conversation

@fabaff
Copy link
Copy Markdown
Member

@fabaff fabaff commented Aug 12, 2023

Description of changes

Fix build (https://hydra.nixos.org/build/230875149)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@fabaff fabaff added the 0.kind: build failure A package fails to build label Aug 12, 2023
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 12, 2023
@fabaff fabaff mentioned this pull request Aug 12, 2023
Merged
12 tasks
@tjni
Copy link
Copy Markdown
Contributor

tjni commented Aug 12, 2023 •
edited
Loading

Thank you for looking into this. Adding wheel is the right thing to do (since this is using poetry-core, I now think wheel isn't needed), but I think the reason this is failing only for the Python 3.11 build is because beautysh in propagatedBuildInputs is built with buildPythonApplication. I think we should fix this by moving it into python-modules.

When I echo $PYTHONPATH in preBuild, we see a lot of Python 3.10 stuff in the path:

/nix/store/idi290dsmxlx808cjls2ybzg97m4j8nn-beautysh-6.2.1/lib/python3.10/site-packages:/nix/store/9i5a9l5bm3krnqjrj4iy1c5q1b6srqdg-python3.10-colorama-0.4.6/lib/python3.10/site-packages:/nix/store/6xmv46hawz0iqgvzwllmagzqc9pws00d-python3-3.10.12/lib/python3.10/site-packages:/nix/store/jcrhwypjidw5hm5kx62ca51qprrb181z-python3.10-setuptools-67.4.0/lib/python3.10/site-packages:/nix/store/szmyxqp3c9b0dqr0mjfkwgb0q37xdc1d-python3.10-types-colorama-0.4.15.12/lib/python3.10/site-packages:/nix/store/l0p3xkxq543hb44nzq77ic1nb2lk817n-python3.10-types-setuptools-67.4.0.3/lib/python3.10/site-packages

@fabaff
Copy link
Copy Markdown
Member Author

fabaff commented Aug 12, 2023

Result of nixpkgs-review pr 248677 run on x86_64-linux 1

2 packages failed to build:
  • python311Packages.mdformat-beautysh
  • python311Packages.mdformat-beautysh.dist
2 packages built:
  • python310Packages.mdformat-beautysh
  • python310Packages.mdformat-beautysh.dist

@ofborg ofborg bot requested a review from aldoborrero August 12, 2023 08:20
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Aug 12, 2023
@tjni
Copy link
Copy Markdown
Contributor

tjni commented Aug 22, 2023

I think that #250713 will also fix the Python 3.11 build failure. I don't think wheel is needed for this build, because it uses poetry-core (and not setuptools), but I think it's a good idea to enable the tests.

@fabaff
Copy link
Copy Markdown
Member Author

fabaff commented Aug 22, 2023

Result of nixpkgs-review pr 248677 run on x86_64-linux 1

4 packages built:
  • python310Packages.mdformat-beautysh
  • python310Packages.mdformat-beautysh.dist
  • python311Packages.mdformat-beautysh
  • python311Packages.mdformat-beautysh.dist

@fabaff fabaff merged commit dd214a5 into NixOS:master Aug 23, 2023
@fabaff
Copy link
Copy Markdown
Member Author

fabaff commented Aug 23, 2023

Buuuhhhh, now the removal of ``wheel goes into a new PR...

@fabaff fabaff mentioned this pull request Aug 23, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aldoborrero aldoborrero Awaiting requested review from aldoborrero

Assignees

No one assigned

Labels

0.kind: build failure A package fails to build 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fabaff @tjni