Skip to content

cc2538-bsl: clean up dependencies and enable tests#248614

Merged
NickCao merged 1 commit intoNixOS:masterfrom
tjni:cc2538-bsl
Aug 13, 2023
Merged

cc2538-bsl: clean up dependencies and enable tests#248614
NickCao merged 1 commit intoNixOS:masterfrom
tjni:cc2538-bsl

Conversation

@tjni
Copy link
Copy Markdown
Contributor

@tjni tjni commented Aug 12, 2023

Description of changes

Clean up some unnecessary dependencies and enable tests using pytestCheckHook (setuptoolsCheckHook was not discovering the tests).

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from lorenz August 12, 2023 03:00
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 12, 2023
Copy link
Copy Markdown
Contributor

@lorenz lorenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NickCao NickCao merged commit 6fe67db into NixOS:master Aug 13, 2023
@tjni tjni deleted the cc2538-bsl branch August 13, 2023 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants