brotab: patch out unnecessary "import pip" in setup.py#248601
Merged
doronbehar merged 1 commit intoNixOS:masterfrom Aug 12, 2023
tjni:brotab
Merged
brotab: patch out unnecessary "import pip" in setup.py#248601doronbehar merged 1 commit intoNixOS:masterfrom tjni:brotab
doronbehar merged 1 commit intoNixOS:masterfrom
tjni:brotab
Conversation
Contributor
|
Hey!
Noticed your work on the Python ecosystem and it is really appreciated! Question:
Why do you add the __darwinAllowLocalNetworking attribute to these PRs?
|
Contributor
Author
|
Hi! Thank you! The |
Contributor
|
It makes sense, I'm just wondering why no Darwin user has ever noticed that this is needed, for the scipy package for example, which is much more common than this.
|
Contributor
Author
|
I'm honestly not sure. I do know that the sandbox is turned off by default on Darwin and is also off on Hydra, so that might be one of the reasons. Also, if someone only uses a stable channel, they might always be able to get it from the binary cache. |
doronbehar
approved these changes
Aug 12, 2023
Contributor
|
Result of 2 packages built:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
In some work I'm doing changing the Python bootstrap, pip is no longer part of the environment by default. This revealed that the setup.py of this project has an "import pip" that is no longer being used.
This is a one line change that could be done with a sed command, but I prefer pulling in the patch I submitted upstream as a signal that this is an upstream problem that should be fixed versus a nixpkgs specific patch.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)