Skip to content

ablog: 0.10.33.post1 -> 0.11.14.post1#248589

Merged
wegank merged 1 commit intoNixOS:masterfrom
tjni:ablog
Aug 12, 2023
Merged

ablog: 0.10.33.post1 -> 0.11.14.post1#248589
wegank merged 1 commit intoNixOS:masterfrom
tjni:ablog

Conversation

@tjni
Copy link
Copy Markdown
Contributor

@tjni tjni commented Aug 11, 2023

Description of changes

There have been a few releases, which you can browse at https://github.com/sunpy/ablog/releases.

What I would like to pick up from this update is:

  1. Removal of pkg_resources, which removes a deprecation message failing tests after updating setuptools to v68.
  2. A switch to using pyproject.toml to bundle the project.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from rgrinberg August 12, 2023 01:09
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 12, 2023
@matthiasbeyer
Copy link
Copy Markdown
Contributor

Result of nixpkgs-review pr 248589 run on x86_64-linux 1

2 packages built:
  • ablog
  • ablog.dist

@wegank wegank merged commit 6315717 into NixOS:master Aug 12, 2023
@tjni tjni deleted the ablog branch August 12, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants