Skip to content

python3.pkgs.diofant: 0.13.0 -> 0.14.0#248511

Merged
natsukium merged 1 commit intoNixOS:masterfrom
tjni:diofant
Aug 12, 2023
Merged

python3.pkgs.diofant: 0.13.0 -> 0.14.0#248511
natsukium merged 1 commit intoNixOS:masterfrom
tjni:diofant

Conversation

@tjni
Copy link
Copy Markdown
Contributor

@tjni tjni commented Aug 11, 2023

Description of changes

https://github.com/diofant/diofant/releases/tag/v0.14.0

I also mimicked upstream by pulling some dependencies out of propagatedBuildInputs and into optional-dependencies.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 11, 2023
@tjni tjni mentioned this pull request Aug 11, 2023
Closed
@ofborg ofborg bot requested a review from suhr August 11, 2023 16:09
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Aug 11, 2023
@natsukium
Copy link
Copy Markdown
Member

natsukium commented Aug 12, 2023

@ofborg build python310Packages.diofant

@natsukium
Copy link
Copy Markdown
Member

natsukium commented Aug 12, 2023

Result of nixpkgs-review pr 248511 run on x86_64-linux 1

4 packages built:
  • python310Packages.diofant
  • python310Packages.diofant.dist
  • python311Packages.diofant
  • python311Packages.diofant.dist

natsukium
natsukium approved these changes Aug 12, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff looks fine.

@natsukium natsukium merged commit d0a26e4 into NixOS:master Aug 12, 2023
@tjni tjni deleted the diofant branch August 12, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@natsukium natsukium natsukium approved these changes

+1 more reviewer

@suhr suhr suhr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tjni @natsukium @suhr