Skip to content

python3.pkgs.orjson: 3.9.2 -> 3.9.4#248273

Merged
FRidh merged 1 commit intoNixOS:stagingfrom
tjni:orjson
Aug 11, 2023
Merged

python3.pkgs.orjson: 3.9.2 -> 3.9.4#248273
FRidh merged 1 commit intoNixOS:stagingfrom
tjni:orjson

Conversation

@tjni
Copy link
Copy Markdown
Contributor

@tjni tjni commented Aug 10, 2023

Description of changes

https://github.com/ijl/orjson/blob/master/CHANGELOG.md#394---2023-08-07

I am especially interested in ijl/orjson@f94318a, which has the following change:

< MAX_INCREASE = 1048576 # 1MiB
> MAX_INCREASE = 2097152 # 2MiB

This increases the amount that one of the tests allows RSS to grow. I have been frequently seeing this test fail time to time, especially when my system is under load building other packages. This ends up costing me a lot of time, because it usually aborts other expensive builds (e.g. other versions of LLVM, gfortran, etc.) that I have running at the same time.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 10, 2023
@ofborg ofborg bot requested a review from misuzu August 10, 2023 05:58
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels Aug 10, 2023
@FRidh FRidh merged commit 03ef702 into NixOS:staging Aug 11, 2023
@tjni tjni deleted the orjson branch August 11, 2023 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants