Skip to content

python3.pkgs.async-generator: rename from async_generator#248081

Merged
natsukium merged 1 commit intoNixOS:masterfrom
tjni:async_generator
Aug 10, 2023
Merged

python3.pkgs.async-generator: rename from async_generator#248081
natsukium merged 1 commit intoNixOS:masterfrom
tjni:async_generator

Conversation

@tjni
Copy link
Copy Markdown
Contributor

@tjni tjni commented Aug 9, 2023

Description of changes

For #245383.

@adisbladis: Does this part in poetry2nix/default.nix need to change?

# Remove Python packages aliases with non-normalized names to avoid issues with infinite recursion (issue #750).
(self: super: {
  # Upstream nixpkgs uses non canonical names
  async-generator = super.async-generator or super.async_generator or null;
})

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 9, 2023
@adisbladis
Copy link
Copy Markdown
Member

adisbladis commented Aug 9, 2023

@adisbladis: Does this part in poetry2nix/default.nix need to change?

# Remove Python packages aliases with non-normalized names to avoid issues with infinite recursion (issue #750).
(self: super: {
  # Upstream nixpkgs uses non canonical names
  async-generator = super.async-generator or super.async_generator or null;
})

I don't think it has to as we're using super and not self.
This shouldn't be a source of infinite recursion.

@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package labels Aug 9, 2023
@ofborg ofborg bot requested a review from dotlambda August 9, 2023 04:30
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Aug 9, 2023
@natsukium natsukium mentioned this pull request Aug 9, 2023
Closed
@natsukium
Copy link
Copy Markdown
Member

natsukium commented Aug 9, 2023

@ofborg build python310Packages.async-generator

@natsukium
Copy link
Copy Markdown
Member

natsukium commented Aug 9, 2023

Result of nixpkgs-review pr 248081 run on x86_64-linux 1

5 packages built:
  • nixops_unstable
  • python310Packages.async-generator
  • python310Packages.async-generator.dist
  • python311Packages.async-generator
  • python311Packages.async-generator.dist

@tjni
Copy link
Copy Markdown
Contributor Author

tjni commented Aug 9, 2023 •
edited
Loading

@ofborg build python310Packages.async-generator

natsukium
natsukium approved these changes Aug 10, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@natsukium natsukium merged commit 07c5633 into NixOS:master Aug 10, 2023
@tjni tjni deleted the async_generator branch August 10, 2023 00:28
@dotlambda
Copy link
Copy Markdown
Member

dotlambda commented Aug 10, 2023

How come this caused rebuilds?

@tjni
Copy link
Copy Markdown
Contributor Author

tjni commented Aug 10, 2023

I'm not sure, probably because I changed the source to use SRI hash.

@dotlambda
Copy link
Copy Markdown
Member

dotlambda commented Aug 11, 2023

No, the only actual rebuild is nixops_unstable. That's related to poetry2nix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@natsukium natsukium natsukium approved these changes

@dotlambda dotlambda Awaiting requested review from dotlambda

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tjni @adisbladis @natsukium @dotlambda