Skip to content

python3.pkgs.snowflake-connector-python: fix build dependencies#248072

Merged
natsukium merged 1 commit intoNixOS:masterfrom
tjni:snowflake-connector-python
Aug 10, 2023
Merged

python3.pkgs.snowflake-connector-python: fix build dependencies#248072
natsukium merged 1 commit intoNixOS:masterfrom
tjni:snowflake-connector-python

Conversation

@tjni
Copy link
Copy Markdown
Contributor

@tjni tjni commented Aug 9, 2023

Description of changes

  1. Add setuptools explicitly to nativeBuildInputs. Right now, it's also picking up the one from propagatedBuildInputs, but in theory one is a build dependency and the other is a host dependency. I think it's more correct to have it in both places.
  2. Add wheel explicitly to nativeBuildInputs. This is included implicitly right now, but I'm working on changing that.
  3. Patch out cython and pyarrow dependencies. We cannot build the C extension with our version of pyarrow, so those dependencies don't make sense for us.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 9, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Aug 9, 2023
@natsukium
Copy link
Copy Markdown
Member

@ofborg build python310Packages.snowflake-connector-python

@natsukium
Copy link
Copy Markdown
Member

Result of nixpkgs-review pr 248072 run on x86_64-linux 1

4 packages marked as broken and skipped:
  • python310Packages.snowflake-sqlalchemy
  • python310Packages.snowflake-sqlalchemy.dist
  • python311Packages.snowflake-sqlalchemy
  • python311Packages.snowflake-sqlalchemy.dist
4 packages failed to build:
  • python310Packages.dbt-snowflake
  • python310Packages.dbt-snowflake.dist
  • python311Packages.dbt-snowflake
  • python311Packages.dbt-snowflake.dist
4 packages built:
  • python310Packages.snowflake-connector-python
  • python310Packages.snowflake-connector-python.dist
  • python311Packages.snowflake-connector-python
  • python311Packages.snowflake-connector-python.dist

Copy link
Copy Markdown
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dbt-snowflake seems to be broken by python-update(?).
https://hydra.nixos.org/build/230986746

LGTM

@natsukium natsukium merged commit 35c1178 into NixOS:master Aug 10, 2023
@tjni
Copy link
Copy Markdown
Contributor Author

tjni commented Aug 10, 2023

Yes, good catch! I'll put it on the list of things to fixl

@tjni tjni deleted the snowflake-connector-python branch August 10, 2023 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants