Skip to content

python3.pkgs.xknxproject: fix up build dependencies#248066

Merged
natsukium merged 1 commit intoNixOS:masterfrom
tjni:xknxproject
Aug 10, 2023
Merged

python3.pkgs.xknxproject: fix up build dependencies#248066
natsukium merged 1 commit intoNixOS:masterfrom
tjni:xknxproject

Conversation

@tjni
Copy link
Copy Markdown
Contributor

@tjni tjni commented Aug 9, 2023

Description of changes

  1. Pull in a patch upstream that unpins setuptools.
  2. Add wheel to nativeBuildInputs. This is implicit right now but I am working on making it explicit.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 9, 2023
@ofborg ofborg bot requested a review from fabaff August 9, 2023 03:00
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Aug 9, 2023
@natsukium
Copy link
Copy Markdown
Member

@ofborg build python310Packages.xknxproject

@natsukium
Copy link
Copy Markdown
Member

Result of nixpkgs-review pr 248066 run on x86_64-linux 1

5 packages built:
  • home-assistant-component-tests.knx
  • python310Packages.xknxproject
  • python310Packages.xknxproject.dist
  • python311Packages.xknxproject
  • python311Packages.xknxproject.dist

@natsukium natsukium merged commit d90ac86 into NixOS:master Aug 10, 2023
@tjni tjni deleted the xknxproject branch August 10, 2023 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants