python310Packages.amazon-kclpy: rename from amazon_kclpy#248014
Merged
wegank merged 1 commit intoNixOS:masterfrom Aug 12, 2023
tjni:amazon-kclpy
Merged
python310Packages.amazon-kclpy: rename from amazon_kclpy#248014wegank merged 1 commit intoNixOS:masterfrom tjni:amazon-kclpy
wegank merged 1 commit intoNixOS:masterfrom
tjni:amazon-kclpy
Conversation
natsukium
requested changes
Aug 12, 2023
Member
natsukium
left a comment
There was a problem hiding this comment.
The commit message is incorrect.
It should be python310Packages.new-attribute-name: rename from old_attribute_name.
Contributor
Author
Whoops, you're right. I don't know what I was thinking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Part of #245383.
This package doesn't properly build, and while the first error I encountered was easy to resolve, it was not obvious to me how to resolve the errors related to trying to download JARs from Maven Central. I don't think it should block this rename.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)