bepasty: add secretKeyFile option#24755
Merged
bennofs merged 1 commit intoNixOS:masterfrom Apr 21, 2017
Merged
Conversation
This gives users the option to store secrets outside the world-readable Nix store.
|
@basvandijk, thanks for your PR! By analyzing the history of the files in this pull request, we identified @makefu and @ehmry to be potential reviewers. |
75 tasks
Contributor
|
@basvandijk thanks for looking after it. If i understand the code correctly then this breaks backwards compatibility, right? Edit: nevermind, saw the fallback is implemented down below 👍 code looks good. |
Contributor
|
Thanks, looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gives users the option to store the secret key outside the world-readable Nix store.
This is part of: #24288.