Skip to content

elinks: use gentoo patch to fix perl 5.38.0 support#247547

Merged
vcunat merged 2 commits intoNixOS:staging-nextfrom
doronbehar:pkg/elinks
Aug 7, 2023
Merged

elinks: use gentoo patch to fix perl 5.38.0 support#247547
vcunat merged 2 commits intoNixOS:staging-nextfrom
doronbehar:pkg/elinks

Conversation

@doronbehar
Copy link
Copy Markdown
Contributor

@doronbehar doronbehar commented Aug 6, 2023

Motivation for this change
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@doronbehar doronbehar mentioned this pull request Aug 6, 2023
Merged
@ofborg ofborg bot requested review from gebner and iblech August 6, 2023 17:30
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Aug 6, 2023
@vcunat vcunat changed the title elinks: always disable perl due to upstream issue with perl 5.38.0 elinks: use gentoo patch to fix perl 5.38.0 support Aug 7, 2023
@vcunat vcunat merged commit 4b6bbec into NixOS:staging-next Aug 7, 2023
@vcunat
Copy link
Copy Markdown
Member

vcunat commented Aug 7, 2023

The PR name and the state in between the two commits was unnecessarily confusing, so I squashed it.

@iblech
Copy link
Copy Markdown
Contributor

iblech commented Aug 8, 2023

Awesome, thank you @doronbehar for tending to the ramifications of the Perl update, and thank you @vcunat for the quick merge! :-)

@doronbehar doronbehar deleted the pkg/elinks branch June 8, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gebner gebner Awaiting requested review from gebner

@iblech iblech Awaiting requested review from iblech

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@doronbehar @vcunat @iblech