stdenv/patchelf hook: filter any RPATHs outside $NIX_STORE#247478
Draft
vcunat wants to merge 1 commit intoNixOS:stagingfrom
Draft
stdenv/patchelf hook: filter any RPATHs outside $NIX_STORE#247478vcunat wants to merge 1 commit intoNixOS:stagingfrom
vcunat wants to merge 1 commit intoNixOS:stagingfrom
Conversation
I can't imagine any use case for keeping such RPATHs by default, and at least our sandboxed builds on Linux would complain: RPATH of binary /nix/store/FOO contains a forbidden reference to /build/ It's not rare that invidual nix expressions had to work around such unwanted references to build dirs, e.g. see commit 3af97fc or lots of "-DCMAKE_SKIP_BUILD_RPATH=ON" (and probably more I've missed)
Member
Author
|
So far I'm opening just to get initial feedback. I haven't done any testing yet, etc. I can imagine conditioning this like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I can't imagine any use case for keeping such RPATHs by default, and at least our sandboxed builds on Linux would complain:
RPATH of binary /nix/store/FOO contains a forbidden reference to /build/
It's not rare that invidual nix expressions had to work around such unwanted references to build dirs, e.g. see commit 3af97fc or lots of "-DCMAKE_SKIP_BUILD_RPATH=ON" (and probably more I've missed)
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)