Closed
Conversation
This commit fixes cross compilation of klayout by adding the `.dev` outputs of its QT dependencies to its `nativeBuildInputs`.
Artturin
reviewed
Aug 28, 2023
Comment on lines
+29
to
+32
| qtbase.dev | ||
| qtmultimedia.dev | ||
| qtxmlpatterns.dev | ||
| qttools.dev |
Member
There was a problem hiding this comment.
the dev output is chosen by stdenv so no need to repeat it
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Requires:
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)This commit fixes cross compilation of klayout by adding the
.devoutputs of its QT dependencies to its
nativeBuildInputs.