dt-schema, python3.pkgs.dtschema: handle jsonschema incompatibility#247379
Merged
vcunat merged 1 commit intoNixOS:staging-nextfrom Aug 8, 2023
tjni:dtschema
Merged
dt-schema, python3.pkgs.dtschema: handle jsonschema incompatibility#247379vcunat merged 1 commit intoNixOS:staging-nextfrom tjni:dtschema
vcunat merged 1 commit intoNixOS:staging-nextfrom
tjni:dtschema
Conversation
1. dt-schema is an application, so it can pin jsonschema to 4.17 2. mark python3.pkgs.dtschema broken with jsonschema > 4.17 3. mark python3.pkgs.dtschema broken on darwin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Some context about each of these points:
This is currently broken on staging-next (#245935).
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)