Skip to content

dt-schema, python3.pkgs.dtschema: handle jsonschema incompatibility#247379

Merged
vcunat merged 1 commit intoNixOS:staging-nextfrom
tjni:dtschema
Aug 8, 2023
Merged

dt-schema, python3.pkgs.dtschema: handle jsonschema incompatibility#247379
vcunat merged 1 commit intoNixOS:staging-nextfrom
tjni:dtschema

Conversation

@tjni
Copy link
Copy Markdown
Contributor

@tjni tjni commented Aug 5, 2023

Description of changes

  1. dt-schema is an application, so it can pin jsonschema to 4.17
  2. mark python3.pkgs.dtschema broken with jsonschema > 4.17
  3. mark python3.pkgs.dtschema broken on Darwin

Some context about each of these points:

  1. Per discussion in Raising the jsonschema cap to allow 4.18.* devicetree-org/dt-schema#108, dt-schema will need more time before it can support jsonschema 4.18.
  2. The package even on master is broken on Darwin right now.

This is currently broken on staging-next (#245935).

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 5, 2023
@ofborg ofborg bot requested a review from sorki August 5, 2023 19:47
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 5, 2023
1. dt-schema is an application, so it can pin jsonschema to 4.17
2. mark python3.pkgs.dtschema broken with jsonschema > 4.17
3. mark python3.pkgs.dtschema broken on darwin
@vcunat vcunat merged commit 3858a9b into NixOS:staging-next Aug 8, 2023
@tjni tjni deleted the dtschema branch August 8, 2023 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants