Skip to content

gnu-config: 2023-01-21 -> 2023-07-31#247325

Merged
sternenseemann merged 3 commits intoNixOS:stagingfrom
sternenseemann:gnu-config-2023-07-31
Aug 6, 2023
Merged

gnu-config: 2023-01-21 -> 2023-07-31#247325
sternenseemann merged 3 commits intoNixOS:stagingfrom
sternenseemann:gnu-config-2023-07-31

Conversation

@sternenseemann
Copy link
Copy Markdown
Member

@sternenseemann sternenseemann commented Aug 5, 2023 •
edited
Loading

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@sternenseemann sternenseemann force-pushed the gnu-config-2023-07-31 branch from d8fffe0 to 986bd7b Compare August 5, 2023 11:20
@sternenseemann sternenseemann requested a review from a user August 5, 2023 11:20
@github-actions github-actions bot added 6.topic: stdenv Standard environment 6.topic: lib The Nixpkgs function library labels Aug 5, 2023
@sternenseemann sternenseemann added the 6.topic: cross-compilation Building packages on a different platform than they will be used on label Aug 5, 2023
@sternenseemann
gnu-config: give sources a name
3314199 
Should be a little bit less of a mess and no shell wildcard symbols in
the store path.
@sternenseemann
gnu-config: use install(1) to make buildCommand simpler
a2e759f
@sternenseemann
gnu-config: 2023-01-21 -> 2023-07-31
f8481f6 
The most interesting change for us is that gnu-config can now [accept]
`*-unknown-none-elf` which means we can use target triples for
lib.systems.*-embedded that are interpreted in the same way by both
nixpkgs and gnu-config.

Reference NixOS#165836.

[accept]: https://git.savannah.gnu.org/cgit/config.git/commit/?id=998ba1414387b4ce1a519be234e1609bc7912e0c
@sternenseemann sternenseemann force-pushed the gnu-config-2023-07-31 branch from 986bd7b to 6b26aaa Compare August 5, 2023 11:22
@sternenseemann sternenseemann changed the base branch from master to staging August 5, 2023 11:22
@ofborg ofborg bot added the 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. label Aug 5, 2023
@ofborg ofborg bot requested review from dezgeg and emilytrau August 5, 2023 13:19
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Aug 5, 2023
@ghost
Copy link
Copy Markdown

ghost commented Aug 5, 2023

@ofborg eval

@ghost
Copy link
Copy Markdown

ghost commented Aug 5, 2023

Could you split out the last commit into a separate PR?

@sternenseemann
Copy link
Copy Markdown
Member Author

sternenseemann commented Aug 5, 2023

I guess so, but there is not really a point, since the changes do depend on each other.

@sternenseemann sternenseemann force-pushed the gnu-config-2023-07-31 branch from 6b26aaa to f8481f6 Compare August 6, 2023 09:51
@sternenseemann sternenseemann changed the title gnu-config: 2023-01-21 -> 2023-07-31; lib.systems.examples: use most canonical embedded triples gnu-config: 2023-01-21 -> 2023-07-31 Aug 6, 2023
@github-actions github-actions bot removed 6.topic: stdenv Standard environment 6.topic: lib The Nixpkgs function library labels Aug 6, 2023
@sternenseemann sternenseemann mentioned this pull request Aug 6, 2023
Open
22 tasks
@sternenseemann
Copy link
Copy Markdown
Member Author

sternenseemann commented Aug 6, 2023

This PR now only contains the gnu-config update which should be easy to merge, the follow lib.systems change is in #247490.

@sternenseemann sternenseemann merged commit 9e910fd into NixOS:staging Aug 6, 2023
@sternenseemann sternenseemann deleted the gnu-config-2023-07-31 branch August 6, 2023 18:22
@ghost ghost mentioned this pull request Aug 14, 2023
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ericson2314 Ericson2314 Ericson2314 approved these changes

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@alyssais alyssais Awaiting requested review from alyssais

@dezgeg dezgeg Awaiting requested review from dezgeg

@emilytrau emilytrau Awaiting requested review from emilytrau

Assignees

No one assigned

Labels

6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sternenseemann @Ericson2314