Skip to content

python3.pkgs.virtualenv: add pip test dependency#247313

Closed
tjni wants to merge 1 commit intoNixOS:stagingfrom
tjni:virtualenv
Closed

python3.pkgs.virtualenv: add pip test dependency#247313
tjni wants to merge 1 commit intoNixOS:stagingfrom
tjni:virtualenv

Conversation

@tjni
Copy link
Copy Markdown
Contributor

@tjni tjni commented Aug 5, 2023

Description of changes

This is needed but hidden by the fact that right now the Python setup hooks add pip to the environment.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@tjni tjni mentioned this pull request Aug 5, 2023
Closed
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 5, 2023
@ofborg ofborg bot requested a review from cillianderoiste August 5, 2023 10:16
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Aug 5, 2023
@FRidh
Copy link
Copy Markdown
Member

FRidh commented Aug 12, 2023 •
edited
Loading

I did not encounter the need for this change while using build/installer.

@tjni
Copy link
Copy Markdown
Contributor Author

tjni commented Aug 12, 2023

You're right, I don't know what was breaking when I tested earlier, but it passes for me now too without this. Thank you for double checking.

@tjni tjni closed this Aug 12, 2023
@tjni tjni deleted the virtualenv branch August 12, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cillianderoiste cillianderoiste Awaiting requested review from cillianderoiste

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tjni @FRidh