Skip to content

python3.pkgs.cvxpy: add build dependencies and fix build constraints#247305

Merged
FRidh merged 1 commit intoNixOS:masterfrom
tjni:cvxpy
Aug 11, 2023
Merged

python3.pkgs.cvxpy: add build dependencies and fix build constraints#247305
FRidh merged 1 commit intoNixOS:masterfrom
tjni:cvxpy

Conversation

@tjni
Copy link
Copy Markdown
Contributor

@tjni tjni commented Aug 5, 2023

Description of changes

We will soon switch to using build to build Python packages, and it validates that all dependencies asked for in pyproject.toml are present, so a few changes are needed to this package.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 5, 2023
@ofborg ofborg bot requested a review from drewrisinger August 5, 2023 09:09
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Aug 5, 2023
@FRidh FRidh merged commit 07fdd83 into NixOS:master Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants