python3.pkgs.clr-loader: add build dependencies #247295
Merged
wegank merged 2 commits intoNixOS:masterfrom Aug 5, 2023
tjni:clr-loader
Merged
python3.pkgs.clr-loader: add build dependencies #247295wegank merged 2 commits intoNixOS:masterfrom tjni:clr-loader
wegank merged 2 commits intoNixOS:masterfrom
tjni:clr-loader
Conversation
Once we add setuptools-scm, we no longer need the patch that changes the version number in pyproject.toml.
mdarocha
approved these changes
Aug 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
The project declares a build dependency on setuptools-scm. By adding this, the patch that replaces the version number in pyproject.toml is no longer necessary.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)