python3.pkgs.botorch: add and move dependencies to nativeBuildInputs#247269
Merged
veprbl merged 1 commit intoNixOS:masterfrom Aug 8, 2023
tjni:botorch
Merged
python3.pkgs.botorch: add and move dependencies to nativeBuildInputs#247269veprbl merged 1 commit intoNixOS:masterfrom tjni:botorch
veprbl merged 1 commit intoNixOS:masterfrom
tjni:botorch
Conversation
veprbl
approved these changes
Aug 5, 2023
Member
|
@GrahamcOfBorg build python3Packages.botorch |
SuperSandro2000
approved these changes
Aug 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This cleans up where the build dependencies should be and will help with #245509.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)