Skip to content

python3.pkgs.ax: add and move some build dependencies#247260

Merged
wegank merged 1 commit intoNixOS:masterfrom
tjni:ax
Aug 5, 2023
Merged

python3.pkgs.ax: add and move some build dependencies#247260
wegank merged 1 commit intoNixOS:masterfrom
tjni:ax

Conversation

@tjni
Copy link
Copy Markdown
Contributor

@tjni tjni commented Aug 5, 2023

Description of changes

Fix up some build dependencies:

  1. Add wheel and setuptools explicitly. This is related to (though not strictly needed) by Switch to PyPA build, installer, and flit-core to build Python packages #245509.
  2. Move setuptools-scm into nativeBuildInputs, where it belongs.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 5, 2023
@ofborg ofborg bot requested a review from veprbl August 5, 2023 03:17
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Aug 5, 2023
@veprbl
Copy link
Copy Markdown
Member

veprbl commented Aug 5, 2023

@GrahamcOfBorg build python3Packages.ax

@wegank wegank merged commit 1c72dc9 into NixOS:master Aug 5, 2023
@tjni tjni deleted the ax branch August 5, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants