Skip to content

python3.pkgs.aioslimproto: improve the derivation#247239

Merged
FRidh merged 1 commit intoNixOS:masterfrom
tjni:aioslimproto
Aug 11, 2023
Merged

python3.pkgs.aioslimproto: improve the derivation#247239
FRidh merged 1 commit intoNixOS:masterfrom
tjni:aioslimproto

Conversation

@tjni
Copy link
Copy Markdown
Contributor

@tjni tjni commented Aug 4, 2023

  1. Grab patch to unpin setuptools version.
  2. Explicitly add wheel as a build dependency.
  3. Add pytest-asyncio, as the project uses it.
  4. Enable a test that now passes.
  5. Update the supported Python version to 3.10+.

Extracted from the original version and required by #245509.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

1. Grab patch to unpin setuptools version.
2. Explicitly add wheel as a build dependency.
3. Add pytest-asyncio, as the project uses it.
4. Enable a test that now passes.
5. Update the supported Python version to 3.10+.
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 4, 2023
@ofborg ofborg bot requested a review from fabaff August 5, 2023 00:58
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Aug 5, 2023
@nixos-discourse
Copy link
Copy Markdown

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/2523

@natsukium
Copy link
Copy Markdown
Member

@ofborg build python310Packages.aioslimproto

@natsukium
Copy link
Copy Markdown
Member

Result of nixpkgs-review pr 247239 run on x86_64-linux 1

5 packages built:
  • home-assistant-component-tests.slimproto
  • python310Packages.aioslimproto
  • python310Packages.aioslimproto.dist
  • python311Packages.aioslimproto
  • python311Packages.aioslimproto.dist

@FRidh FRidh merged commit b2ad86c into NixOS:master Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants