Skip to content

python3.pkgs.hydra-core: unbreak on darwin#247207

Merged
wegank merged 1 commit intoNixOS:masterfrom
tjni:hydra-core
Aug 5, 2023
Merged

python3.pkgs.hydra-core: unbreak on darwin#247207
wegank merged 1 commit intoNixOS:masterfrom
tjni:hydra-core

Conversation

@tjni
Copy link
Copy Markdown
Contributor

@tjni tjni commented Aug 4, 2023

Description of changes

It looks like this package was marked broken over a year ago in a tree-wide cleanup, but now it has no problems building for me on aarch64-darwin. It's status is unknown on x86_64-darwin because its dependency omegaconf is broken. I'd like to address that separately and optimistically assume that whatever fixed the build in the past on aarch64-darwin also applies to x86_64-darwin.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 4, 2023
@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Aug 4, 2023
@tjni
Copy link
Copy Markdown
Contributor Author

tjni commented Aug 4, 2023

@ofborg build python3.pkgs.hydra-core

@wegank
Copy link
Copy Markdown
Member

wegank commented Aug 4, 2023

Wait, is jre_minimal broken on x86_64-darwin?

@tjni
Copy link
Copy Markdown
Contributor Author

tjni commented Aug 4, 2023

Wait, is jre_minimal broken on x86_64-darwin?

I don't know at the moment if it's jre_minimal or how omegaconf uses it. It's on a list of things I want to look at :)

@wegank wegank merged commit e30571e into NixOS:master Aug 5, 2023
@tjni tjni deleted the hydra-core branch August 5, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: darwin Running or building packages on Darwin 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants