python3.pkgs.hydra-core: unbreak on darwin#247207
Merged
wegank merged 1 commit intoNixOS:masterfrom Aug 5, 2023
tjni:hydra-core
Merged
python3.pkgs.hydra-core: unbreak on darwin#247207wegank merged 1 commit intoNixOS:masterfrom tjni:hydra-core
wegank merged 1 commit intoNixOS:masterfrom
tjni:hydra-core
Conversation
Contributor
Author
|
@ofborg build python3.pkgs.hydra-core |
Member
|
Wait, is |
Contributor
Author
I don't know at the moment if it's |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
It looks like this package was marked broken over a year ago in a tree-wide cleanup, but now it has no problems building for me on aarch64-darwin. It's status is unknown on x86_64-darwin because its dependency omegaconf is broken. I'd like to address that separately and optimistically assume that whatever fixed the build in the past on aarch64-darwin also applies to x86_64-darwin.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)