python2.pkgs.backports-functools-lru-cache: init at 1.6.6#246976
Merged
wegank merged 2 commits intoNixOS:masterfrom Aug 5, 2023
tjni:python2-backport
Merged
python2.pkgs.backports-functools-lru-cache: init at 1.6.6#246976wegank merged 2 commits intoNixOS:masterfrom tjni:python2-backport
wegank merged 2 commits intoNixOS:masterfrom
tjni:python2-backport
Conversation
12 tasks
natsukium
approved these changes
Aug 3, 2023
Member
natsukium
left a comment
There was a problem hiding this comment.
fahcontrol works fine with NIXPKGS_ALLOW_INSECURE=1 nix-build -A fahcontrol.
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/2495 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This is a minimal restoration of this package to python2-modules to resolve #246631.
I'm supportive of the effort to update FAH, but I also see that the GIMP plugin issue seems unresolvable without someone putting concentrated effort into it upstream.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)