Skip to content

python3.pkgs.hydra-core: fix tests with setuptools 67.5.0+#246922

Merged
risicle merged 1 commit intoNixOS:masterfrom
tjni:hydra-core
Aug 3, 2023
Merged

python3.pkgs.hydra-core: fix tests with setuptools 67.5.0+#246922
risicle merged 1 commit intoNixOS:masterfrom
tjni:hydra-core

Conversation

@tjni
Copy link
Copy Markdown
Contributor

@tjni tjni commented Aug 3, 2023

Description of changes

Extracted from #245509. When setuptools is updated to 67.5.0+, a new deprecation warning is emitted that fails the tests. We can pull in a patch that ignores this deprecation warning in tests.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 3, 2023
@ofborg ofborg bot requested a review from bcdarwin August 3, 2023 07:30
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Aug 3, 2023
Copy link
Copy Markdown
Contributor

@risicle risicle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, WFM nixos x86_64

@risicle risicle merged commit d29508c into NixOS:master Aug 3, 2023
@tjni tjni deleted the hydra-core branch August 3, 2023 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants