Skip to content

python3.pkgs.josepy: fix tests with setuptools 67.5.0+#246920

Merged
FRidh merged 1 commit intoNixOS:stagingfrom
tjni:josepy
Aug 11, 2023
Merged

python3.pkgs.josepy: fix tests with setuptools 67.5.0+#246920
FRidh merged 1 commit intoNixOS:stagingfrom
tjni:josepy

Conversation

@tjni
Copy link
Copy Markdown
Contributor

@tjni tjni commented Aug 3, 2023

Description of changes

Extracted from #245509. When setuptools is updated to 67.5.0+, a new deprecation warning is emitted that fails the tests. We can pull in a patch that stops using setuptools.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 3, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. labels Aug 3, 2023
@tjni tjni marked this pull request as draft August 3, 2023 07:23
@tjni tjni changed the base branch from master to staging August 3, 2023 07:24
@tjni tjni marked this pull request as ready for review August 3, 2023 07:24
@tjni tjni mentioned this pull request Aug 5, 2023
Closed
@nixos-discourse
Copy link
Copy Markdown

nixos-discourse commented Aug 9, 2023

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1054

@figsoda figsoda added the 12.approvals: 1 This PR was reviewed and approved by one person. label Aug 9, 2023
@natsukium
Copy link
Copy Markdown
Member

natsukium commented Aug 11, 2023 •
edited
Loading

@ofborg build python311packages.josepy

@FRidh FRidh merged commit 9dd8601 into NixOS:staging Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tjni @nixos-discourse @natsukium @SuperSandro2000 @FRidh @figsoda