Skip to content

python3.pkgs.jupyter-packaging: fix tests with setuptools 67.5.0+#246919

Merged
FRidh merged 1 commit intoNixOS:masterfrom
tjni:jupyter-packaging
Aug 12, 2023
Merged

python3.pkgs.jupyter-packaging: fix tests with setuptools 67.5.0+#246919
FRidh merged 1 commit intoNixOS:masterfrom
tjni:jupyter-packaging

Conversation

@tjni
Copy link
Copy Markdown
Contributor

@tjni tjni commented Aug 3, 2023

Description of changes

Extracted from #245509. When setuptools is updated to 67.5.0+, a new deprecation warning is emitted that fails the tests. We can pull in a patch that ignores this deprecation warning in tests.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 3, 2023
@ofborg ofborg bot requested a review from elohmeier August 3, 2023 06:35
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Aug 3, 2023
@nixos-discourse
Copy link
Copy Markdown

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1054

@figsoda figsoda added the 12.approvals: 1 This PR was reviewed and approved by one person. label Aug 9, 2023
@natsukium
Copy link
Copy Markdown
Member

@ofborg build python310Packages.jupyter-packaging

@FRidh FRidh merged commit 30df053 into NixOS:master Aug 12, 2023
@tjni tjni deleted the jupyter-packaging branch August 12, 2023 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants