Skip to content

python3.pkgs.qcodes: add build and test dependencies and fix constraints#246912

Merged
fabaff merged 1 commit intoNixOS:masterfrom
tjni:qcodes
Aug 8, 2023
Merged

python3.pkgs.qcodes: add build and test dependencies and fix constraints#246912
fabaff merged 1 commit intoNixOS:masterfrom
tjni:qcodes

Conversation

@tjni
Copy link
Copy Markdown
Contributor

@tjni tjni commented Aug 3, 2023

Description of changes

Extracted from #245509. When we use build to build packages instead of pip:

  1. We need to add pip as an explicit test dependency.
  2. We'd like to add wheel as an explicit build dependency.
  3. We need to relax a build dependency version in pyproject.toml so that new dependency constraint logic passes.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 3, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Aug 3, 2023
@fabaff
Copy link
Copy Markdown
Member

fabaff commented Aug 8, 2023

Result of nixpkgs-review pr 246912 run on x86_64-linux 1

12 packages built:
  • python310Packages.qcodes
  • python310Packages.qcodes-contrib-drivers
  • python310Packages.qcodes-contrib-drivers.dist
  • python310Packages.qcodes-loop
  • python310Packages.qcodes-loop.dist
  • python310Packages.qcodes.dist
  • python311Packages.qcodes
  • python311Packages.qcodes-contrib-drivers
  • python311Packages.qcodes-contrib-drivers.dist
  • python311Packages.qcodes-loop
  • python311Packages.qcodes-loop.dist
  • python311Packages.qcodes.dist

Copy link
Copy Markdown
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me.

@fabaff fabaff merged commit c93aac9 into NixOS:master Aug 8, 2023
@tjni tjni deleted the qcodes branch August 8, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants