python3.pkgs.rdflib: add pip test dependency#246909
Merged
natsukium merged 1 commit intoNixOS:masterfrom Aug 11, 2023
tjni:rdflib
Merged
python3.pkgs.rdflib: add pip test dependency#246909natsukium merged 1 commit intoNixOS:masterfrom tjni:rdflib
natsukium merged 1 commit intoNixOS:masterfrom
tjni:rdflib
Conversation
SuperSandro2000
approved these changes
Aug 3, 2023
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1054 |
Member
|
@ofborg build python310Packages.rdflib |
Member
|
Result of 8 packages failed to build:
60 packages built:
|
natsukium
approved these changes
Aug 11, 2023
Member
natsukium
left a comment
There was a problem hiding this comment.
I don't think this change would have broken any other builds, and in fact, it's irrelevant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Extracted from #245509. When we use build to build packages instead of pip, we need to add pip as an explicit test dependency.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)