Skip to content

python3.pkgs.cx-freeze: switch to pyproject and rename#246900

Merged
FRidh merged 2 commits intoNixOS:masterfrom
tjni:cx-freeze
Aug 7, 2023
Merged

python3.pkgs.cx-freeze: switch to pyproject and rename#246900
FRidh merged 2 commits intoNixOS:masterfrom
tjni:cx-freeze

Conversation

@tjni
Copy link
Copy Markdown
Contributor

@tjni tjni commented Aug 3, 2023

Description of changes

  1. Switch to pyproject.toml, which upstream already uses. Extracted from Switch to PyPA build, installer, and flit-core to build Python packages #245509 when I was testing something. Unfortunately, I don't remember what now, but we should still do this.
  2. Normalize its attribute name, part of Normalize python-modules attribute names and pnames #245383.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 3, 2023
@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package labels Aug 3, 2023
@ofborg ofborg bot requested a review from mausch August 3, 2023 04:16
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Aug 3, 2023
@mausch
Copy link
Copy Markdown
Member

mausch commented Aug 3, 2023

LGTM 👍
Too bad #243787 hasn't been merged yet, which makes it more difficult to test this.

@tjni
Copy link
Copy Markdown
Contributor Author

tjni commented Aug 3, 2023

Thanks for the review! Hope yours gets committed soon too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants