python3Packages.pytest-ansible: 3.1.5 -> 3.2.1#246735
python3Packages.pytest-ansible: 3.1.5 -> 3.2.1#246735Janik-Haag merged 2 commits intoNixOS:masterfrom tjni:pytest-ansible
Conversation
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/2508 |
|
Result of 4 packages built:
|
Janik-Haag
left a comment
There was a problem hiding this comment.
This looks good except for the commit message. Can you change the commit message to the same as the Pull Request name?
In addition, add missing nativeBuildInputs that are implicitly added right now, and configure setuptools-scm so that a _version.py file is created like in the PyPI archive.
Thank you for reviewing! Done. |
Janik-Haag
left a comment
There was a problem hiding this comment.
LGTM:
non blocker: but would you mind adding your self as a maintainer since the package currently doesn't have one?
|
No problem, done :) |
Janik-Haag
left a comment
There was a problem hiding this comment.
nice, just waiting for ci now.
In addition, add missing nativeBuildInputs that are implicitly added right now, and configure setuptools-scm so that a _version.py file is created like in the PyPI archive.
https://github.com/ansible-community/pytest-ansible/releases/tag/v3.2.1
https://github.com/ansible-community/pytest-ansible/releases/tag/v3.2.0
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)