Skip to content

zziplib: fix build with clang 15+#246691

Merged
AndersonTorres merged 1 commit intoNixOS:masterfrom
reckenrode:zziplib-clang16
Aug 2, 2023
Merged

zziplib: fix build with clang 15+#246691
AndersonTorres merged 1 commit intoNixOS:masterfrom
reckenrode:zziplib-clang16

Conversation

@reckenrode
Copy link
Copy Markdown
Contributor

Description of changes

Fix invalid pointer conversions flagged by clang as an error.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Fix invalid pointer conversions flagged by clang as an error.
@ofborg ofborg bot requested a review from AndersonTorres August 2, 2023 03:01
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Aug 2, 2023
@AndersonTorres AndersonTorres merged commit f97f08c into NixOS:master Aug 2, 2023
@reckenrode reckenrode deleted the zziplib-clang16 branch August 2, 2023 11:50
@reckenrode
Copy link
Copy Markdown
Contributor Author

Result of nixpkgs-review pr 246691 run on aarch64-darwin 1

20 packages marked as broken and skipped:
  • diffoscope
  • diffoscope.dist
  • diffoscope.man
  • frescobaldi
  • frescobaldi.dist
  • giac
  • giac.doc
  • herwig
  • lua54Packages.luazip
  • milkytracker
  • python310Packages.cnvkit
  • python310Packages.cnvkit.dist
  • python311Packages.cnvkit
  • python311Packages.cnvkit.dist
  • sherpa
  • therion
  • xyce
  • xyce-parallel
  • xyce-parallel.doc
  • xyce.doc
6 packages failed to build:
  • python310Packages.fpylll
  • python310Packages.fpylll.dist
  • python310Packages.paranoid-crypto
  • python310Packages.paranoid-crypto.dist
  • python311Packages.fpylll
  • python311Packages.fpylll.dist
134 packages built:
  • R
  • advi
  • asciidoc-full
  • asciidoc-full-with-plugins
  • asciidoc-full-with-plugins.dist
  • asciidoc-full.dist
  • asymptote
  • auctex
  • auctex.tex
  • auto-multiple-choice
  • blahtexml
  • blahtexml.doc
  • cddlib
  • cegui
  • dblatex
  • dblatexFull
  • dot2tex (python310Packages.dot2tex)
  • dot2tex.dist (python310Packages.dot2tex.dist)
  • eclib
  • evince
  • evince.dev
  • evince.devdoc
  • gap
  • gap-full
  • gap-minimal
  • gfan
  • gnu-cobol
  • gnu-cobol.bin
  • gnu-cobol.dev
  • gnu-cobol.lib
  • gp2c
  • kakounePlugins.rep
  • latte-integrale
  • lcalc
  • lilypond
  • lilypond-unstable
  • lilypond-unstable-with-fonts
  • lilypond-with-fonts
  • lua51Packages.luazip
  • lua52Packages.luazip
  • lua53Packages.luazip
  • luajitPackages.luazip
  • manga-cli
  • mpd
  • mpd-small
  • mpd-small.doc
  • mpd.doc
  • mpd.man
  • ne
  • nuweb
  • ocamlPackages.ocaml-r
  • ogre
  • ogre_13
  • pari
  • postgresql11JitPackages.plr
  • postgresql11Packages.plr
  • postgresql12JitPackages.plr
  • postgresql12Packages.plr
  • postgresql13JitPackages.plr
  • postgresql13Packages.plr
  • postgresqlJitPackages.plr (postgresql14JitPackages.plr)
  • postgresql14Packages.plr
  • postgresql15JitPackages.plr
  • postgresql15Packages.plr
  • pynac
  • python310Packages.cypari2
  • python310Packages.cypari2.dist
  • python310Packages.cysignals
  • python310Packages.cysignals.dist
  • python310Packages.pplpy
  • python310Packages.pplpy.dist
  • python310Packages.pplpy.doc
  • python310Packages.primecountpy
  • python310Packages.primecountpy.dist
  • python310Packages.pypandoc
  • python310Packages.pypandoc.dist
  • python310Packages.radian
  • python310Packages.radian.dist
  • python310Packages.rchitect
  • python310Packages.rchitect.dist
  • rivet (python310Packages.rivet)
  • python310Packages.rpy2
  • python310Packages.rpy2.dist
  • python310Packages.sphinxcontrib-bayesnet
  • python310Packages.sphinxcontrib-bayesnet.dist
  • python310Packages.sphinxcontrib-tikz
  • python310Packages.sphinxcontrib-tikz.dist
  • python310Packages.unstructured
  • python310Packages.unstructured.dist
  • python311Packages.cypari2
  • python311Packages.cypari2.dist
  • python311Packages.cysignals
  • python311Packages.cysignals.dist
  • python311Packages.dot2tex
  • python311Packages.dot2tex.dist
  • python311Packages.pplpy
  • python311Packages.pplpy.dist
  • python311Packages.pplpy.doc
  • python311Packages.primecountpy
  • python311Packages.primecountpy.dist
  • python311Packages.pypandoc
  • python311Packages.pypandoc.dist
  • python311Packages.radian
  • python311Packages.radian.dist
  • python311Packages.rchitect
  • python311Packages.rchitect.dist
  • python311Packages.rivet
  • python311Packages.rpy2
  • python311Packages.rpy2.dist
  • python311Packages.sphinxcontrib-bayesnet
  • python311Packages.sphinxcontrib-bayesnet.dist
  • python311Packages.sphinxcontrib-tikz
  • python311Packages.sphinxcontrib-tikz.dist
  • python311Packages.unstructured
  • python311Packages.unstructured.dist
  • rWrapper
  • radianWrapper
  • sagetex
  • singular
  • texlive.combined.scheme-basic
  • texlive.combined.scheme-context
  • texlive.combined.scheme-full
  • texlive.combined.scheme-gust
  • texlive.combined.scheme-infraonly
  • texlive.combined.scheme-medium
  • texlive.combined.scheme-minimal
  • texlive.combined.scheme-small
  • texlive.combined.scheme-tetex
  • thepeg
  • vimPlugins.openscad-nvim
  • wayback-machine-archiver
  • wayback-machine-archiver.dist
  • zathura
  • zziplib

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants