Skip to content

glibcLocales: fix extraNativeBuildInputs definition#246537

Merged
yu-re-ka merged 1 commit intoNixOS:stagingfrom
yu-re-ka:musl-glibclocales
Aug 2, 2023
Merged

glibcLocales: fix extraNativeBuildInputs definition#246537
yu-re-ka merged 1 commit intoNixOS:stagingfrom
yu-re-ka:musl-glibclocales

Conversation

@yu-re-ka
Copy link
Copy Markdown
Contributor

@yu-re-ka yu-re-ka commented Aug 1, 2023

Description of changes

b243596 moved the extraNativeBuildInputs definition down into an overrideAttrs block, but it doesn't have any effect there

can be tested with nix-build -E "with import ./. {}; pkgsMusl.callPackage ./pkgs/development/libraries/glibc/locales.nix { allLocales = false; }"¨

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@yu-re-ka yu-re-ka requested a review from a user August 1, 2023 10:24
@ofborg ofborg bot added 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Aug 1, 2023
@yu-re-ka yu-re-ka changed the base branch from master to staging August 1, 2023 13:45
@ghost
Copy link
Copy Markdown

ghost commented Aug 1, 2023

@ofborg eval

@ghost
Copy link
Copy Markdown

ghost commented Aug 1, 2023

ofborg is cranky today

@yu-re-ka yu-re-ka merged commit 7197b9f into NixOS:staging Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants