glibcLocales: disable parallelism to restore deterministic locales#246049
Merged
vcunat merged 1 commit intoNixOS:stagingfrom Aug 11, 2023
Merged
glibcLocales: disable parallelism to restore deterministic locales#246049vcunat merged 1 commit intoNixOS:stagingfrom
vcunat merged 1 commit intoNixOS:stagingfrom
Conversation
ghost
reviewed
Jul 29, 2023
|
Building on:
|
The way `nixpkgs` runs parallel `localedef` instances shares
`--prefix=/build` flag. As a result `localedef` processes
non-deterministically extend the file with new locales (hopefully
without data corruption):
NixOS#245360
Co-authored-by: Adam Joseph <54836058+amjoseph-nixpkgs@users.noreply.github.com>
7b72aee to
43da9e8
Compare
|
@ofborg eval |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The way
nixpkgsruns parallellocaledefinstances shares--prefix=/buildflag. As a resultlocaledefprocesses non-deterministically extend the file with new locales (hopefully without data corruption):Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)