linuxManualConfig: fix inaccurate FIXME comment#245968
Merged
Conversation
I read this comment, checked out 4.19, saw that it didn't have any instances of /bin/pwd, and rejoiced, assuming that the removal must have been backported to the affected kernels. But actually, /bin/pwd was just removed earlier, in 4.15, so kernels older than that are still affected. Fix the version number in the comment so I don't go through exactly the same process again a few months from now next time I'm working on this file.
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reapplies #230679 after the revert of #221707 in #245449.
Description of changes
I read this comment, checked out 4.19, saw that it didn't have any instances of /bin/pwd, and rejoiced, assuming that the removal must have been backported to the affected kernels. But actually, /bin/pwd was just removed earlier, in 4.15, so kernels older than that are still affected.
Fix the version number in the comment so I don't go through exactly the same process again a few months from now next time I'm working on this file.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)