texlive: fix build with clang 16#245806
Merged
drupol merged 1 commit intoNixOS:masterfrom Jul 29, 2023
Merged
Conversation
There are two instances of `main` with an implicit `int` return type. This is fixed upstream, so this patch is to allow texlive-2022 to build until texlive-2023 is merged into nixpkgs.
AndersonTorres
approved these changes
Jul 28, 2023
Contributor
Author
|
I’m going to push a commit with the correct message. I’m also going to retarget master because texlive only has ~100 rebuilds. Edit: Also, thank you for correcting the PR title. |
Contributor
Author
|
Result of 18 packages marked as broken and skipped:
6 packages failed to build:
121 packages built:
|
Contributor
Author
|
Result of 11 packages marked as broken and skipped:
5 packages failed to build:
131 packages built:
|
Contributor
Author
|
diffoscope failed to build on x86_64-darwin because one of its tested hanged, and I killed it. I don’t know if it’s related to running under Rosetta 2 or what the issue is. |
xworld21
approved these changes
Jul 28, 2023
Contributor
|
@GrahamcOfBorg build tests.texlive for good measure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
There are two instances of
mainwith an implicitintreturn type. This is fixed upstream, so this patch is to allow texlive-2022 to build until texlive-2023 is merged into nixpkgs.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)