Skip to content

python3.pkgs.flit-core: remove passthru tests#245671

Merged
FRidh merged 1 commit intoNixOS:stagingfrom
tjni:flit-core-remove-tests
Aug 7, 2023
Merged

python3.pkgs.flit-core: remove passthru tests#245671
FRidh merged 1 commit intoNixOS:stagingfrom
tjni:flit-core-remove-tests

Conversation

@tjni
Copy link
Copy Markdown
Contributor

@tjni tjni commented Jul 27, 2023

Description of changes

These tests are run as part of building the "flit" application. There are no flit-core specific tests. Doing this lets us simplify the build of flit-core a little bit.

I discovered this while working on bootstrapping flit-core and decided to break this out as its own PR. Organized this way, it's one less detail that will need to reviewed in those bootstrapping PRs.

Extracted from #245509.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jul 27, 2023
@ofborg ofborg bot added the 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. label Jul 27, 2023
@ofborg ofborg bot requested a review from FRidh July 27, 2023 08:09
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Jul 27, 2023
These tests are run as part of building the "flit" application. There
are no flit-core specific tests.
@tjni tjni changed the title python310Packages.flit-core: remove passthru tests python3.pkgs.flit-core: remove passthru tests Jul 28, 2023
@nixos-discourse
Copy link
Copy Markdown

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/2497

@FRidh FRidh merged commit decf1f8 into NixOS:staging Aug 7, 2023
@tjni tjni deleted the flit-core-remove-tests branch August 7, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants