python3.pkgs.flit-core: remove passthru tests#245671
Merged
FRidh merged 1 commit intoNixOS:stagingfrom Aug 7, 2023
tjni:flit-core-remove-tests
Merged
python3.pkgs.flit-core: remove passthru tests#245671FRidh merged 1 commit intoNixOS:stagingfrom tjni:flit-core-remove-tests
FRidh merged 1 commit intoNixOS:stagingfrom
tjni:flit-core-remove-tests
Conversation
These tests are run as part of building the "flit" application. There are no flit-core specific tests.
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/2497 |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
These tests are run as part of building the "flit" application. There are no flit-core specific tests. Doing this lets us simplify the build of
flit-corea little bit.I discovered this while working on bootstrapping flit-core and decided to break this out as its own PR. Organized this way, it's one less detail that will need to reviewed in those bootstrapping PRs.
Extracted from #245509.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)