luaPackages.mpack: 1.0.9 -> 1.0.10#245644
Merged
teto merged 1 commit intoNixOS:stagingfrom Oct 3, 2023
Merged
Conversation
This update fixes compilation with clang 15+.
Contributor
Author
|
@ofborg eval |
toonn
reviewed
Sep 30, 2023
Contributor
toonn
left a comment
There was a problem hiding this comment.
I can't reproduce the failure on 9ae5c2d. Am I bungling the override?
nix-build --pure --no-out-link -E 'with import ./. {}; (lua.override { inherit (llvmPackages_16) stdenv; callPackage = newScope { inherit (llvmPackages_16) stdenv; }; }).pkgs.mpack'
Member
|
@toonn what do you mean ? if it doesnt change things for you I think we can merge, I've checked that neovim builds at least |
Contributor
|
@teto, I can't reproduce the failure with newer Clang. This means I can't rely on no failure after the bump occurring as a signal for whether or not this works. I don't expect any problems but I try to be diligent in testing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This update fixes compilation with clang 15+.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)