python311Packages.hologram: pull patch to fix tests#245152
Merged
fpletz merged 1 commit intoNixOS:masterfrom Aug 9, 2023
tjni:hologram
Merged
python311Packages.hologram: pull patch to fix tests#245152fpletz merged 1 commit intoNixOS:masterfrom tjni:hologram
fpletz merged 1 commit intoNixOS:masterfrom
tjni:hologram
Conversation
Contributor
Author
|
Converting into a draft so that I can merge it with 18601b8 when it hits |
mausch
approved these changes
Jul 29, 2023
The tests were failing due to dataclass changes in Python 3.11.
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1053 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
The tests were failing due to dataclass changes in Python 3.11 (python/cpython#88840). Pulling in dbt-labs/hologram#58.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)