Skip to content

gccWithoutTargetLibc: link libgcc_s.so using -mnewlib if isPower#244406

Merged
1 commit merged intomasterfrom
unknown repository
Jul 20, 2023
Merged

gccWithoutTargetLibc: link libgcc_s.so using -mnewlib if isPower#244406
1 commit merged intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Jul 19, 2023

Description of changes

Closes #244405

Also adds considerably more commenting to document what is going on.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

gccWithoutTargetLibc: link libgcc_s.so using -mnewlib if isPower
424952b 
Closes #244405

Also adds considerably more commenting to document what is going on.
@ghost ghost requested a review from matthewbauer as a code owner July 19, 2023 20:20
@ghost
Copy link
Copy Markdown
Author

ghost commented Jul 19, 2023

@ofborg build tests.cross.sanity

@ghost
Copy link
Copy Markdown
Author

ghost commented Jul 19, 2023 •
edited by ghost
Loading

tests.cross.sanity on x86_64-linux — Success Details

@ghost
Copy link
Copy Markdown
Author

ghost commented Jul 19, 2023

Rebased to get ofborg unstuck.

@ghost
Copy link
Copy Markdown
Author

ghost commented Jul 20, 2023

Ofborg is still stuck.

@ghost
Copy link
Copy Markdown
Author

ghost commented Jul 20, 2023

Since ofborg appears to have died, I ran its tests myself:

nix-build --option substituters https://cache.nixos.org --option trusted-public-keys 'cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=' --arg pkgs 'import ./. {}' ./lib/tests/release.nix

...

/nix/store/m5r1dyiarcjb801db4cgj156hv4z73q6-nixpkgs-lib-tests

and

curl -o outpaths.nix https://raw.githubusercontent.com/NixOS/ofborg/released/ofborg/src/outpaths.nix;
GC_INITIAL_HEAP_SIZE=16g nix-env -f ./outpaths.nix -qaP --no-name --out-path --arg checkMeta true > out-paths
wc -l out-paths

...

214805 out-paths

@ghost ghost merged commit 4d92ffb into NixOS:master Jul 20, 2023
@ghost ghost deleted the pr/fix/244405 branch January 23, 2024 06:47
@Artturin Artturin mentioned this pull request Jan 29, 2024
Open
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

pkgsCross.powernv.stdenv broken by #238154

0 participants