longview service: don't write passwords to nix store#24366
Merged
7c6f434c merged 1 commit intoNixOS:masterfrom May 1, 2017
Merged
longview service: don't write passwords to nix store#243667c6f434c merged 1 commit intoNixOS:masterfrom
7c6f434c merged 1 commit intoNixOS:masterfrom
Conversation
Adds services.longview.{apiKeyFile,mysqlPasswordFile} options as
alternatives to apiKey and mysqlPassword, which still work, but are
deprecated with a warning message.
Related to NixOS#24288.
Contributor
Author
|
/cc @basvandijk |
75 tasks
7c6f434c
reviewed
May 1, 2017
| apiKeyFile = mkOption { | ||
| type = types.nullOr types.path; | ||
| default = null; | ||
| example = "/run/keys/longview-api-key"; |
Member
There was a problem hiding this comment.
Shouldn't the example be something with /var/keys? /run/keys would need to be refilled on every reboot…
Member
There was a problem hiding this comment.
We use /run/keys in all the examples of #24288 because that's what nixops is using. See: https://nixos.org/nixops/manual/#idm140737318306400
Contributor
Author
|
Thanks @basvandijk, @7c6f434c 🌲 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
services.longview.{apiKeyFile,mysqlPasswordFile}options as alternatives toapiKeyandmysqlPassword, which still work, but are deprecated with a warning message.Related to #24288.
Motivation for this change
Security.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)Testing note: This PR is rebased to master branch but I actually did the testing on nixos-unstable.