libredirect: fix build with clang 16#243558
Merged
vcunat merged 1 commit intoNixOS:stagingfrom Jul 26, 2023
Merged
Conversation
* Preferentially use the stdenv clang if it is new enough to produce arm64e binaries; and * Fix incompatible function pointer conversions (results in an error with clang 16).
Contributor
|
This LGTM based on observing the code and some fiddling around locally. I unfortunately can't test this end-to-end on my aarch64-darwin machine, because the libredirect that I build doesn't work (either on master or staging-next), perhaps because I'm on Ventura. If you're curious, the error is: |
tjni
approved these changes
Jul 15, 2023
Contributor
tjni
left a comment
There was a problem hiding this comment.
LGTM if we change the branch to staging due to the number of rebuilds.
Contributor
|
Whoa, that error only happens with SIP disabled. |
Contributor
Author
|
Result of 119 packages marked as broken and skipped:
38 packages failed to build:
207 packages built:
|
Contributor
Author
|
I retargeted to staging because of the number of Linux rebuilds. |
Contributor
Author
Does it also happen without the patch? That is a weird error. |
Contributor
Author
|
Result of 119 packages marked as broken and skipped:
47 packages failed to build:
197 packages built:
|
Contributor
Author
|
Checking some of the failures against master on aarch64-darwin:
|
Contributor
Author
|
For x86_64-darwin, borgbackup and diffoscope are failing due to e2fsprogs. That failure should be fixed in staging with the stdenv rework and CF updates. |
Contributor
Yeah, it happens without the patch too. Something to worry about for another day. |
Contributor
Author
That means it’s not a regression. 🤓 |
vcunat
reviewed
Jul 26, 2023
| WRAPPER(int, openat)(int dirfd, const char * path, int flags, ...) | ||
| { | ||
| int (*openat_real) (int, const char *, int, mode_t) = LOOKUP_REAL(openat); | ||
| int (*openat_real) (int, const char *, int, ...) = LOOKUP_REAL(openat); |
Member
There was a problem hiding this comment.
Eh, I expect someone was looking at Linux docs instead of POSIX. I'm prone to doing that mistake, too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)