Skip to content

keybase: fix build on x86_64-darwin#243555

Merged
wegank merged 1 commit intoNixOS:masterfrom
reckenrode:keybase-fix
Jul 15, 2023
Merged

keybase: fix build on x86_64-darwin#243555
wegank merged 1 commit intoNixOS:masterfrom
reckenrode:keybase-fix

Conversation

@reckenrode
Copy link
Copy Markdown
Contributor

Description of changes

Go is built with the 11.0 SDK, so build Keybase with the same SDK to prevent build failures due to mixed SDKs.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Go is built with the 11.0 SDK, so build Keybase with the same SDK to
prevent build failures due to mixed SDKs.
@reckenrode
Copy link
Copy Markdown
Contributor Author

Result of nixpkgs-review pr 243555 run on aarch64-darwin 1

@reckenrode
Copy link
Copy Markdown
Contributor Author

Result of nixpkgs-review pr 243555 run on x86_64-darwin 1

1 package built:
  • keybase

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jul 15, 2023
@wegank wegank merged commit 634bd0d into NixOS:master Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants