doctest: fix build with clang 16#243547
Merged
Artturin merged 1 commit intoNixOS:masterfrom Aug 3, 2023
Merged
Conversation
Contributor
Author
|
Result of 21 packages marked as broken and skipped:
4 packages failed to build:
67 packages built:
|
Contributor
Author
|
Result of 21 packages marked as broken and skipped:
4 packages failed to build:
67 packages built:
|
Contributor
Author
|
python3Packages.xtensor-python fails to build on 23.05, so I don’t think the failure is caused by this change. |
Artturin
reviewed
Aug 1, 2023
Member
There was a problem hiding this comment.
Suggested change
| url = "https://github.com/doctest/doctest/pull/768.patch"; | |
| url = "https://github.com/doctest/doctest/commit/9336c9bd86e3fc2e0c36456cad8be3b4e8829a22.patch"; |
The pull request can change, so it's better to use a rev.
verify that the hash is still the same.
Contributor
Author
There was a problem hiding this comment.
I pushed an update that uses the commit rather than the PR patch.
01fb404 to
5722356
Compare
Clang 16 adds a buffer hardening mode as a new warning. doctest enables all warnings and promotes them to errors, which causes the build to fail with clang 16. The upstream PR suppresses these warnings on clang 16. Background: https://discourse.llvm.org/t/rfc-c-buffer-hardening/65734
5722356 to
8bde040
Compare
Artturin
reviewed
Aug 3, 2023
|
|
||
| patches = [ | ||
| # Suppress unsafe buffer usage warnings with clang 16, which are treated as errors due to `-Werror`. | ||
| # https://github.com//doctest/doctest/pull/768 |
Member
There was a problem hiding this comment.
PR link should be included in the comment, added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Clang 16 adds a buffer hardening mode as a new warning. doctest enables all warnings and promotes them to errors, which causes the build to fail with clang 16. The upstream PR suppresses these warnings on clang 16.
Background: https://discourse.llvm.org/t/rfc-c-buffer-hardening/65734
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)