CODEOWNERS: ping @amjoseph-nixpkgs on certain trees#243391
Merged
1 commit merged intomasterfrom Jul 14, 2023
unknown repository
Merged
CODEOWNERS: ping @amjoseph-nixpkgs on certain trees#2433911 commit merged intomasterfrom unknown repository
1 commit merged intomasterfrom
unknown repository
Conversation
I don't claim ownership of anything, but I would like to be notified of PRs opened against the following paths where I've put a lot of work into cleanup and deduplication: lib/systems pkgs/stdenv pkgs/build-support/cc-wrapper pkgs/development/compilers/gcc Apparently CODEOWNERS is how you tell github you want to be notified of such things.
Mic92
approved these changes
Jul 14, 2023
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
I don't claim ownership of anything, but I would like to be notified of PRs opened against the following paths where I've put a lot of work into cleanup and deduplication:
lib/systemspkgs/stdenvpkgs/build-support/cc-wrapperpkgs/development/compilers/gccThings done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Apparently CODEOWNERS is how you tell github you want to be notified
of such things.