ssmtp: use the authPassFile option instead of authPass#24331
Merged
Mic92 merged 2 commits intoNixOS:masterfrom Apr 8, 2017
Merged
ssmtp: use the authPassFile option instead of authPass#24331Mic92 merged 2 commits intoNixOS:masterfrom
Mic92 merged 2 commits intoNixOS:masterfrom
Conversation
|
@basvandijk, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @abbradar and @the-kenny to be potential reviewers. |
75 tasks
Mic92
reviewed
Mar 26, 2017
Member
There was a problem hiding this comment.
Can you add yourself as maintainer, when adding patches likes this?
Member
Author
There was a problem hiding this comment.
Make sense. I just added myself. I will also try to upstream this patch to Debian.
960b114 to
7ced938
Compare
This gives users the option of storing the authPass outside the world-readable Nix store.
7ced938 to
1d52c67
Compare
Member
Author
|
Any chance this can be merged? I would like to make some progress on #24288. |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gives users the option of storing the smtp password outside the world-readable Nix store.
This is part of: #24288.
I tested this by configuring ssmtp to send mail via my mandrill account:
and then sending some mail.
I also tested it by setting
authPassFileto a non-existing file or a file with too restrictive permissions. In those cases the correct error message is printed:Setting
authPassFileto an empty file correctly produces the following error message: