Skip to content

streamlit: 1.24.0 -> 1.24.1; move to python-modules#242594

Merged
marsam merged 4 commits intoNixOS:masterfrom
natsukium:streamlit/update
Aug 6, 2023
Merged

streamlit: 1.24.0 -> 1.24.1; move to python-modules#242594
marsam merged 4 commits intoNixOS:masterfrom
natsukium:streamlit/update

Conversation

@natsukium
Copy link
Copy Markdown
Member

@natsukium natsukium commented Jul 10, 2023

Description of changes

Changelog: https://github.com/streamlit/streamlit/releases/tag/1.24.1

As this comment suggests, streamlit is more valuable as a library than a standalone application.

I decided to keep streamlit at the top-level and manage it as python-modules.

The concern in this comment was addressed by running the following tutorial.
https://docs.streamlit.io/library/get-started/create-an-app#lets-put-it-all-together

cc @risicle @felschr

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jul 10, 2023
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Jul 10, 2023
@ofborg ofborg bot requested a review from yrashk July 10, 2023 05:40
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jul 10, 2023
@natsukium
Copy link
Copy Markdown
Member Author

I have resolved the conflict.
I don't see any disagreement, so I think we can move on.

@natsukium
Copy link
Copy Markdown
Member Author

Result of nixpkgs-review run on x86_64-linux 1

4 packages built:
  • streamlit (python310Packages.streamlit)
  • streamlit.dist (python310Packages.streamlit.dist)
  • python311Packages.streamlit
  • python311Packages.streamlit.dist

@marsam marsam merged commit fc48d4b into NixOS:master Aug 6, 2023
@natsukium natsukium deleted the streamlit/update branch August 6, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants